Popup code not being output
Hello,
I have created a popup with the display trigger set to "On Click" (but other display triggers are the same) and the visibility set to "Entire Site", however the popup doesn't work.
A link has been created with an href of #mfn-popup-template-400 and target blank. Clicking on it opens a new window with #mfn-popup-template-400 appended to the URL.
When inspecting the source code, there is no element with this ID.
Can you advise what I may be missing to get this to work on click? Is there something that could be stopping the HTML being included on the site?
You can see the site at https://www.temporary-url.com/540B
Comments
Hi,
Did you follow this video tutorial?:
https://support.muffingroup.com/video-tutorials/open-popup-on-link-click/
Please check it, and ensure that you done all steps correctly.
Best regards
Thanks, not exactly following that tutorial for one element, as it is an icon element in BeBuilder. A regular link has also been tested.
The issue is that the HTML of the pop-up element isn't in the source code, so it can't open something that isn't there.
Also, I believe the functionality has been improved since the video was made. The popup builder suggests adding an external link to "a button" (which I assume means regular <a> link too) with the href of #mfn-popup-template-400.
The video suggests adding classes to the link as well as a data attribute.
The class and data attribute shown in the video is the improvement because previously, only the button had the option to open a popup. Now only element that can trigger the popup is the button, or you can show it with a link, as shown in the video.
We plan to add popups to all or most elements in BeBuilder, but I do not know when this feature will be available.
Best regards
Hi Phil,
Sorry, its a little confusing then.
I would have thought the details in the screenshot above within the popup builder was more flexible (and up to date/accurate).
E.g. An <a> tag with the href attribute set to #mfn-popup-template-XXX
Your JS could then look for any <a> tag with href beginning with #mfn-popup-template-
The issue still persists that the source code is still not output for the popup. No matter what way it is attempted to be triggered, it isn't there to be called.
Please send us WordPress dashboard access privately thru the contact form, which is on the right side at http://themeforest.net/user/muffingroup#contact and we will check what might be the reason.
Notice!
Please attach a link to this forum discussion.
Thanks
Thanks, details sent.
Sorry, but the login credentials you sent are not working.
Are you sure that they are correct?
Best regards
Sorry, please try muffin.support as the username. The rest should be the same.
I think we misunderstood each other.
Currently, popups cannot be triggered from other elements than the Button, or by a custom link like shown in the video tutorial I sent you. So you cannot use the icon element for that.
Best regards
I'm confused - as the builder for the popup template clearly shows the below:
Even in testing using a button with the "advanced" functional button option, it doesn't work as there HTML output of the popup is not in the source code.
You can view the "Popup test" page in the admin of the system to try a button of your own.
Could you please ignore the part about triggering the popup for now and help understand why the code for the popup content isn't in the source code?
In the description, it says that the popup opens with a button.
Regarding popup opening, your child theme is the root cause. When I deactivated it, the popup opened correctly.
Best regards
Thanks, It seems to have been the footer.php file in the child theme. Thanks for helping with that.
I have been able to replicate the functionality by redoing the code in elements to follow the class and data attributes.
The popup, however, doesn't seem to be honouring the padding set in the configuration (you can see this in your screenshot too).
p.s. Could you please remove the screenshot above to avoid the client site details being published?
Screenshot removed.
I regenerated CSS on your website through Betheme -> Tools, and padding in the popup appeared. Can you confirm?
Best regards
Great, thanks - now resolved. Appreciated, as always.
Was there an issue in the original generation of the CSS? Something to pass on to check out?
The popup might not be saved correctly, or CSS was not complete. If regeneration helped, there is no need to check this out because, for this type of situation, this option was added. ?
Best regards
OK, thanks for your help.