Lightbox gone after 17.8.3 update

jperez-murcia · May 2017

I have some iframes opened inside "lightbox" with the help of Visual Composer's "Icon Box". In this way, the content works as a modal window.

After upgrading to BeTheme 17.8.3, the "Lightbox" just don't appear. The iframe is opened in a new navigator tab.

Getting things back to 17.8.2 all works again.

Tried to update plugins to the last version included in 17.8.4 don't help. With the last plugin version and with BeTheme up to 17.8.2 all works ok. So, no plugins problems, just something wrong with BeTheme...

Bryan · May 2017

Hi,
Please send a link to the website and point us in the right direction.
thanks

jperez-murcia · May 2017

[Links visible only for registered users]

Scroll down the "hero" image and click over any of the aircrafts "Icon Boxes" you'll find. You will get a "Lightbox" dialog with an iframe content. The content could be any "normal" Wordpress page.

Right now, the site is working with BeTheme 17.8.1 . After upgrading to the next version, the content appear in a new tab, not inside any "Lightbox" ... Sorry, obviously I can't show you both situations ...

Bryan · May 2017

Ok, we see but we need to actually check the updated version to see what could be wrong. Could you make a copy of the page on your server and send us a link to the updated version?
You can use this plugin to quickly copy the site : [Links visible only for registered users]
We really cannot say what is wrong if everything is working right.

jperez-murcia · May 2017

Easiest way ...

Now you can go to [Links visible only for registered users]

and see how the content isn't opened in a "Lightbox" ....

Bryan · May 2017

Please use this code to make the popup work.

<a rel="prettyphoto" href="#you-custom-id">link</a>
<div id="you-custom-id" style="display:none">popup content here</div>

jperez-murcia · May 2017

if the code was running before without any need to code a single line, why don't you solve the problem inside your code instead ?

Bryan · May 2017

The popup is working fine, you just have some wierd problems with it. The shortcode is working a well, http://themes.muffingroup.com/be/theme/shortcodes/typography/#popup
thanks

jperez-murcia · June 2017

I have tested your shortcode [button] what includes "rel" param and a "lightbox" destination ... and same result ... up to 17.8.2 all works and the hlink opens in a "lightbox" or "prettyphoto" window. Any later version don't ...

[Links visible only for registered users]

at the end of the scroll, on the right side, there are two buttons. Upper one is an "Advanced Button" from the "Ultimate Add-ons for ..." package, and the following is your shortcode [button] .

Both worked correctly up to 17.8.2

Bryan · June 2017

Yes, because we changed the popup plugin.
[Links visible only for registered users]
Version 17.8.3

jperez-murcia · June 2017

Ok. Could you give me any idea on how to use Magnific Popup now?

jperez-murcia · June 2017

I can see many people having problems since you removed the prettyPhoto plugin. Moreover, many wordpress plugins, even Visual Composer, still relies on prettyPhoto functions.

In my honest opinion, you can't make this change without a previous evaluation of the damages.

It's ok if you think that "Magnific Popup" is best than PrettyPhoto, but you can't damage your clients websites.

Bryan · June 2017

We do not damage anything, we still support :
rel="ligtbox"
rel="prettyphoto"
Everything is working fine. You are adding some iframes, we do not support custom code you put in your website. If you check on a photo it will work fine.

jperez-murcia · June 2017

I'm not adding custom code nor asking you to support it. It's well known and documented that prettyPhoto plugin supports <iframes> using the url query string, same as "Magnific Popup" does --of course, not using the url, but using "type=iframe" param in the jQuery call. But seems you haven't coded this option; once again, it's ok to change plugins, but you can't "hurt" another "pieces of code" because you haven't coded some parts ..

Bryan · June 2017

Here you have both option to display a popup window (shortcode and html code) in the text editor:
[Links visible only for registered users]
And they both work [Links visible only for registered users]

jperez-murcia · June 2017

Hi. That's ok to add a custom anchor, but what's if I want to launch the lightbox+iframe from any of your link objects?

Javascript supports the onclick event for any object. Why don't you add the OnClick to any object where you have placed a Link property in the same way you did with the "button" object?

Here [Links visible only for registered users] you can see in the first yellow band, several "Feature Boxes"; as there isn't any way to interact with the OnClick event, a button with "more info" should be used; it's doing their job but isn't the more aesthetic solution.

Why don't add the OnClick to any "clickable" item?

Bryan · June 2017

Hi sorry but we do not have OnClick events, you can add them if you know how but for now this is not possible.

thanks

jperez-murcia · June 2017

Ok, solved by my own ...

But, please, take note about the fact that your "button" shortcode includes a "onclick" field to fill in the OnClick event for the underlying object.

At last, to be coherent along all shortcode objects, all items including a button should has this same field. Just take it in consideration for future updates.

Thanks for your help

Lightbox gone after 17.8.3 update

Comments

This website uses cookies